Change build tmp dir to support parallel builds#1338
Merged
Conversation
dyaandys
requested changes
Jul 24, 2025
Contributor
dyaandys
left a comment
There was a problem hiding this comment.
My apologies Gil .. it should have been JOB_NAME.
Otherwise it looks fine.
dyaandys
requested changes
Jul 24, 2025
Contributor
dyaandys
left a comment
There was a problem hiding this comment.
Hmm .. I think the issue is that the packaging tool does not like having tmp under the top level directory .. we see errors like
Error: Cannot copy '.' to a subdirectory of itself,
in the Jenkins output. So I think we'll have to back off some of the changes while we think more about this.
Can we therefore for now alter mk:
`diff --git a/mk b/mk
index 2e54a6d2..e430ad5f 100755
--- a/mk
+++ b/mk
@@ -51,11 +51,17 @@ const incl = new RegExp('^$'
const pkg = (x, y, f) => {
const version = isDyalogBuild ? process.env.APPVERSION : v;
let tmpdir;
- if (process.env.JOB_NAME) {
- tmpdir =
${process.env.WORKSPACE}/tmp; - } else {
- tmpdir =
/tmp/ridebuild_${version}_${rq('os').userInfo().username}_${process.pid}; - }
+// Creating tmpdir under WORKSPACE under Jenkins would be preferable, but that currently
+// leads to errors like "Error: Cannot copy '.' to a subdirectory of itself, "
+// so for now create tmpdir in /tmp. This code doesn't tidy up after itself so
+// for now we'll create a per-user directory which results in just one or
+// two tmpdirs, but avoids the permissions issues seen when using just one tmpdir
+// if (process.env.JOB_NAME) {
+// tmpdir =${process.env.WORKSPACE}/tmp;
+// } else {
+// tmpdir =/tmp/ridebuild_${version}_${rq('os').userInfo().username}_${process.pid};
+// }
- tmpdir =
/tmp/ridebuild_${version}_${rq('os').userInfo().username};
rq('@electron/packager')({
dir: '.',
platform: x,
`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1322