Merged
Conversation
- Update `ci.yml` with minimum constraint for `numpy` and `xarray` - Add doc dependencies for `ci.yml` - Update `dev.yml` base section to match `ci.yml` - Remove `prod.yml` and update docs with commands to get latest stable release of e3sm_diags - Remove `docs.yml` and use `ci.yml` in GH Action builds - Remove `prod.yml` section from `tbump.toml`
Contributor
|
Looks good to me. |
tomvothecoder
commented
Jun 20, 2023
Collaborator
Author
tomvothecoder
left a comment
tomvothecoder
left a comment
There was a problem hiding this comment.
My review comments
| - sphinx | ||
| - sphinx_rtd_theme | ||
| - sphinx-multiversion | ||
| # Developer Tools |
Collaborator
Author
There was a problem hiding this comment.
The QA tools such as black and flake8 should still be pinned to exact versions because newer versions usually flag new warnings or errors. We should manually update these ourselves and fix the subsequent issues (if they are produced with newer versions).
Comment on lines
+25
to
+26
| - numpy >=1.23.0 | ||
| - xarray >=2023.02.0 |
Collaborator
Author
There was a problem hiding this comment.
I constrained numpy >=1.23.0 because that one supports Python 3.11 (future-proofing).
I constrained xarray >=2023.02.0 because that one drops Python 3.8 support.
| # ================== | ||
| - python>=3.8 | ||
| # ================= | ||
| - python >=3.9 |
Collaborator
Author
There was a problem hiding this comment.
Bumped minimum Python version to 3.9.
Comment on lines
+9
to
+34
| - python >=3.9 | ||
| - pip | ||
| - beautifulsoup4 | ||
| - cartopy >=0.17.0 | ||
| - cartopy_offlinedata | ||
| - cdp 1.7.0 | ||
| - cdms2 3.1.5 | ||
| - cdutil 8.2.1 | ||
| - dask | ||
| - genutil 8.2.1 | ||
| - lxml | ||
| - mache >=0.15.0 | ||
| - matplotlib-base | ||
| - netcdf4 | ||
| - numpy >=1.23.0 | ||
| - xarray >=2023.02.0 | ||
| # Testing | ||
| # ================== | ||
| - scipy | ||
| - pytest | ||
| - pytest-cov | ||
| # Documentation | ||
| # ================= | ||
| - sphinx | ||
| - sphinx_rtd_theme | ||
| - sphinx-multiversion |
Collaborator
Author
There was a problem hiding this comment.
This section replicates ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conda-env#695This PR simplifies the conda env yml files by merging yml files together and loosening up constraints.
By no longer pinning exact dependencies, the conda environments will use the latest compatible dependencies. This ensures a higher chance of compatibility within E3SM Unified because we will be testing on similar dependency versions.
The trade-off is we lose stability and deterministic environments between developers, which might make it a bit more difficult to reproduce bugs or behaviors. There are only a few developers in this repo so it's not that big of a deal to communicate environment setups and dependency versions.
Summary of Changes:
ci.ymlwith minimum constraint fornumpyandxarrayci.ymldev.ymlbase section to matchci.ymlprod.ymland update docs with commands to get latest stable release of e3sm_diagsdocs.ymland useci.ymlin GH Action buildsprod.ymlsection fromtbump.toml