Port over cdp_viewer.OutputViewer and remove cdp dependency#773
Merged
tomvothecoder merged 2 commits intomainfrom Jan 3, 2024
Merged
Port over cdp_viewer.OutputViewer and remove cdp dependency#773tomvothecoder merged 2 commits intomainfrom
cdp_viewer.OutputViewer and remove cdp dependency#773tomvothecoder merged 2 commits intomainfrom
Conversation
- Update all references to `core_viewer.py` module
cdp dependencycdp_viewer.OutputViewer and remove cdp dependency
tomvothecoder
commented
Jan 3, 2024
| https://docs.dask.org/en/stable/generated/dask.dataframe.DataFrame.compute.html | ||
| """ | ||
| bag = dask.bag.from_sequence(parameters) | ||
| bag = db.from_sequence(parameters) |
Collaborator
Author
There was a problem hiding this comment.
For some reason this modules throws AttributeError: module 'dask' has no attribute 'bag' even though the dask version is the same as main (dask=2023.12.1).
I don't know the root cause, but import dask.bag as db fixes the issue.
chengzhuzhang
pushed a commit
that referenced
this pull request
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ports over the
cdp_viewer.OutputViewermodule that is used by all of the viewer modules ine3sm_diags. It also removes thecdpdependency entirely frome3sm_diags. No other code was changed and the viewer output behaves the same.cdp.viewer.OutputViewerfromcdppackage #628Checklist
If applicable: