Skip to content

Fix tmp directories#652

Merged
forsyth2 merged 3 commits intomainfrom
issue-636-tmp
Dec 10, 2024
Merged

Fix tmp directories#652
forsyth2 merged 3 commits intomainfrom
issue-636-tmp

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Dec 10, 2024

Issue resolution

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

1. Does this do what we want it to do?

Objectives:

  • Fix temp directory permissions
  • Give temp directories more descriptive names

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

If applicable:

  • Testing: this pull request introduces an important feature or bug fix that we must test often. I have updated the weekly-test configuration files, not just a "min-case" one.
  • Testing: this pull request adds at least one new possible parameter to the cfg. I have tested using this parameter with and without any other parameter that may interact with it.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.
  • Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

  • Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy/conda, not just an import statement.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

If applicable:

  • Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

@forsyth2 forsyth2 marked this pull request as ready for review December 10, 2024 17:15
@forsyth2
Copy link
Collaborator Author

For reference, as of this PR:

  • bash files have permissions: -rwxrw----
  • Other files have permissions: -rw-rw----
  • tmp directories have permissions: drwxrws---

@forsyth2 forsyth2 self-assigned this Dec 10, 2024
@forsyth2 forsyth2 added the semver: bug Bug fix (will increment patch version) label Dec 10, 2024
@forsyth2 forsyth2 merged commit fb66c6c into main Dec 10, 2024
@forsyth2 forsyth2 deleted the issue-636-tmp branch December 10, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: bug Bug fix (will increment patch version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Change permissions and ownership for the temp directories to be the same as the parent directory

1 participant