Use ref_final_yr for model vs model

[chengzhuzhang]

Summary

The problem might be introduced from abad674. This PR is to revert the change regarding to ref_end_yr:

1. revert to use ref_final_yr as other variability sets.
2. remove checking this variable

Issue resolution:

• Closes [Bug]: Error from parameter checking: raise ParameterNotProvidedError(relevant_parameter) #666

Select one: This pull request is...

• a bug fix: increment the patch version
• a small improvement: increment the minor version
• a new feature: increment the minor version
• an incompatible (non-backwards compatible) API change: increment the major version

Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.

Small Change

• To merge, I will use "Squash and merge". That is, this change should be a single commit.
• Logic: I have visually inspected the entire pull request myself.
• Pre-commit checks: All the pre-commits checks have passed.

Big Change

• To merge, I will use "Create a merge commit". That is, this change is large enough to require multiple units of work (i.e., it should be multiple commits).

1. Does this do what we want it to do?

Required:

• Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
• Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
• Testing: I have considered likely and/or severe edge cases and have included them in testing.

If applicable:

• Testing: this pull request introduces an important feature or bug fix that we must test often. I have updated the weekly-test configuration files, not just a "min-case" one.
• Testing: this pull request adds at least one new possible parameter to the cfg. I have tested using this parameter with and without any other parameter that may interact with it.

2. Are the implementation details accurate & efficient?

Required:

• Logic: I have visually inspected the entire pull request myself.
• Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

• Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy/conda, not just an import statement.

3. Is this well documented?

Required:

• Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?

Required:

• Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
• Pre-commit checks: All the pre-commits checks have passed.

If applicable:

• Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

[forsyth2]

@chengzhuzhang Ok, I think these changes look good. The unit tests and integration test cfgs will need to be updated though. I can add a commit for those changes if you'd like. Thanks.

[forsyth2]

We can probably just remove this then.

[forsyth2]

In zppy/templates/e3sm_diags.bash, we have:

{% if run_type == "model_vs_obs" %}
# Obs
trop_param.reference_data_path = '{{ obs_ts }}'
trop_param.ref_start_yr = 2001
trop_param.ref_end_yr = 2010

Those are hard coded, so we're good to delete this check here, yes

[forsyth2]

I think these are always put in as 4-digit years, so this change should be ok

[chengzhuzhang]

@forsyth2 thanks for a review. Could you go ahead to update the tests? Thanks.

[forsyth2]

Added a 3rd commit, will use merge commit to preserve authorship of the different commits. Unit tests pass.