Skip to content

Improve res handling in tc_analysis#689

Merged
forsyth2 merged 1 commit intomainfrom
issue-688-res
Mar 11, 2025
Merged

Improve res handling in tc_analysis#689
forsyth2 merged 1 commit intomainfrom
issue-688-res

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Mar 11, 2025

Summary

Objectives:

  • Add res parameter for users to set resolution explicitly, in the case that zppy can't infer it.
  • Fix the regex pattern matching that caused incorrect resolution inference for some grids.

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Mar 11, 2025
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang Please 1) visually inspect the changes in the zppy directory and 2) run the cfg that was initially causing issues with this updated code.

Once I get approval to merge this, I can work on the next zppy RC.

@forsyth2 forsyth2 merged commit 1f1c08f into main Mar 11, 2025
5 checks passed
@forsyth2 forsyth2 deleted the issue-688-res branch March 11, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tc_analysis task won't infer resolution res from ne120ne4pg2 files

1 participant