Conversation
forsyth2
commented
Mar 11, 2025
Collaborator
Author
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang Please 1) visually inspect the changes in the zppy directory and 2) run the cfg that was initially causing issues with this updated code.
Once I get approval to merge this, I can work on the next zppy RC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Objectives:
resparameter for users to set resolution explicitly, in the case thatzppycan't infer it.Issue resolution:
resfrom ne120ne4pg2 files #688Select one: This pull request is...
Small Change