Conversation
|
@chengzhuzhang Is this ready for review? |
Yes, thank you! |
There was a problem hiding this comment.
@chengzhuzhang Using the ilamb "min-case" cfg, I'm able to produce results with no errors in the output directory (/lcrc/group/e3sm/ac.forsyth2/zppy_min_case_ilamb_output/test_pr696_20250325/v3.LR.historical_0051/post/scripts).
Note that my results page has fewer valid results than your results, likely because the cfg you ran zppy on specified more variables (and it looks like both were run on the same simulation data).
It's possible there will be changes in expected results for integration testing due to the changes in /templates/ directory, but these can be updated in aggregate with updated results from other pre-release PRs.
Overall, I think this is good to merge if you have no further follow-ups.
|
thank you for reviewing and testing. Yes, in my case, I included generating time series for all 2d atmospere and land variables that we can cmorize, thus generated max number of ilamb figures. |
Summary
When going over the ilamb output with @thorntonpe , it appears that maps comparing with CERES ebaf 4.1 was not showing up in diagnostics results, even if the radiation fields are cmorized. It looks like in ilamb data config, it updated to use CERES ebaf 4.2 to replace 4.1. After updated the data config for ilamb in zppy repo. Diagnostics from most fields are created: ILAMB run example..
With this update, the only missing variables are now:
Boimass
CO2
Soil Carbon
Surface Relative Humidity
We should be able to bring in these variables, with cmorized input.
Select one: This pull request is...
Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.
Small Change
Big Change
1. Does this do what we want it to do?
Required:
If applicable:
2. Are the implementation details accurate & efficient?
Required:
If applicable:
zppy/conda, not just animportstatement.3. Is this well documented?
Required:
4. Is this code clean?
Required:
If applicable: