Conversation
c08f916 to
014402b
Compare
014402b to
d0cfe41
Compare
|
I think this is good to merge; I just want to run on the full test suite. Since the code changes only affect the tests and not user-facing code, it won't be a problem if this merges after the Unified testing deadline. |
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang Let me know if you want to review this test-side-only change. Otherwise, I think this should be good to merge (aside from a couple dict keys I think I'll rename first).
Key points:
- Most of the things that need to be changed between test runs are now at the very top of the
utilsfile. That is, the environments, thecfgs to run, the tasks/sets to run, and the unique test run id. - This change allows a tester to auto-generate only the requested cfgs and to run the image checker on only the requested results directories & task subdirectories. This is currently possible via cumbersome commenting of the test code. These changes make it easier to toggle that functionality on/off. This would be useful for example when most of the tests are passing, but we just want to test a small change in
ilamb(i.e., no need to re-rune3sm_diagstoo). - I tested this commit on
mpas_analysis,global_time_series, andilambduring my testing of E3SM-Project/zppy-interfaces#26. I only left oute3sm_diagsbecause of the diffs noted in the thread at #634 (comment). As expected,e3sm_diagstests were skipped rather than failed.
tests/integration/utils.py
Outdated
| "weekly_legacy_3.0.0_comprehensive_v2", | ||
| "weekly_legacy_3.0.0_comprehensive_v3", | ||
| ], | ||
| "sets_to_run": ["e3sm_diags", "mpas_analysis", "global_time_series", "ilamb"], |
There was a problem hiding this comment.
I guess this might be better labeled "tasks_to_run"
tests/integration/utils.py
Outdated
| TEST_SPECIFICS: Dict[str, Any] = { | ||
| "diags_environment_commands": "source <INSERT PATH TO CONDA>/conda.sh; conda activate <INSERT ENV NAME>", | ||
| "global_time_series_environment_commands": "source <INSERT PATH TO CONDA>/conda.sh; conda activate <INSERT ENV NAME>", | ||
| "tests_to_run": [ |
There was a problem hiding this comment.
I guess this might be better labeled "cfgs_to_run"
@chengzhuzhang I just want to re-ping you on this. I'd like to include this change for this week's weekly testing and other PR testing. |
chengzhuzhang
left a comment
There was a problem hiding this comment.
I had a visual check, the changes look good for me.
|
Latest commit 093ae2f just changes the (internal testing) parameter names to be better descriptors. Visual inspection/search confirms all were changed. This is now good to merge. |
Summary
Objectives:
cfgs to run and which sets to run the image checker on. This will be quite useful when one test fails and we want to re-run it without running all the other jobs and/or tests unnecessarily.Issue resolution:
Select one: This pull request is...
Small Change