Conversation
forsyth2
commented
Dec 2, 2025
Collaborator
Author
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang Please let me know if I should change anything here. I think this should be fine to merge. We can test it as part of the next weekly test on main.
| fi | ||
| # Now, call ncclimo | ||
| cat input.txt | ncclimo \ | ||
| cat input.txt | {{ ncclimo_cmd }} \ |
Collaborator
Author
There was a problem hiding this comment.
I suppose one possible use case not covered by this PR is wanting a different ncclimo on this call than in the first call in this file. I think that's an unlikely use case though.
chengzhuzhang
approved these changes
Dec 2, 2025
Collaborator
chengzhuzhang
left a comment
There was a problem hiding this comment.
The code change looks good to me based on visual check.
Collaborator
Author
|
Thanks @chengzhuzhang! |
This was referenced Dec 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Objectives:
Issue resolution:
Select one: This pull request is...
Small Change