Skip to content

Add NCO version parameter#761

Merged
forsyth2 merged 1 commit intomainfrom
issue-734-nco-version
Dec 2, 2025
Merged

Add NCO version parameter#761
forsyth2 merged 1 commit intomainfrom
issue-734-nco-version

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Nov 26, 2025

Summary

Objectives:

  • Add NCO version parameter

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Nov 26, 2025
@forsyth2 forsyth2 added the semver: small improvement Small improvement (will increment patch version) label Nov 26, 2025
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang Please let me know if I should change anything here. I think this should be fine to merge. We can test it as part of the next weekly test on main.

fi
# Now, call ncclimo
cat input.txt | ncclimo \
cat input.txt | {{ ncclimo_cmd }} \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose one possible use case not covered by this PR is wanting a different ncclimo on this call than in the first call in this file. I think that's an unlikely use case though.

Copy link
Collaborator

@chengzhuzhang chengzhuzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me based on visual check.

@forsyth2 forsyth2 merged commit ff357da into main Dec 2, 2025
6 checks passed
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Dec 2, 2025

Thanks @chengzhuzhang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: small improvement Small improvement (will increment patch version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add parameter to choose NCO version

2 participants