Skip to content

adds metadata to output#59

Merged
jmbhughes merged 6 commits intomainfrom
fix-#33
Jun 6, 2024
Merged

adds metadata to output#59
jmbhughes merged 6 commits intomainfrom
fix-#33

Conversation

@jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Jun 6, 2024

PR summary

  • Adds metadata to output
  • Improves documentation about units

Todos

  • Finish metadata propagation
  • Make sure everything always passes as an ndcube
  • Test the metadata propagation

Test plan

Actually write some unit tests

Breaking changes

None

Related Issues

@jmbhughes jmbhughes self-assigned this Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.92%. Comparing base (c6ae31a) to head (7f015cc).

Files Patch % Lines
overlappogram/io.py 74.19% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #59       +/-   ##
==========================================
+ Coverage   0.00%   82.92%   +82.92%     
==========================================
  Files          7        7               
  Lines        370      410       +40     
  Branches      61       71       +10     
==========================================
+ Hits           0      340      +340     
+ Misses       370       54      -316     
- Partials       0       16       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes marked this pull request as ready for review June 6, 2024 20:48
@jmbhughes jmbhughes merged commit 6b6d9cb into main Jun 6, 2024
@jmbhughes jmbhughes deleted the fix-#33 branch June 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document weights units as 1/sigma Improve file output format Write at least a few tests

1 participant