Load data only once for ESMPy regridders#2418
Merged
valeriupredoi merged 1 commit intomainfrom May 14, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14020 14023 +3
=======================================
+ Hits 13251 13254 +3
Misses 769 769 ☔ View full report in Codecov by Sentry. |
schlunma
approved these changes
May 14, 2024
Contributor
schlunma
left a comment
There was a problem hiding this comment.
Thanks Bouwe, looks great!
Would it maybe make sense to include that into v2.11.0? This sounds like a serious performance issue.
Member
Author
|
@chrisbillowsMO @ehogan Would it be possible to include this in the upcoming v2.11 release? |
valeriupredoi
approved these changes
May 14, 2024
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
and a very good spotting, cheers @bouweandela and @schlunma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Realize the data only once for the ESMPy regridders.
Closes ESMValGroup/ESMValTool#3590
Test recipe:
With these changes, the recipe takes less than a minute to run on my laptop. I did not wait for the process to complete (killed it after about 10 minutes), but reportedly it takes about an hour without these changes.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: