Open
Conversation
|
The following contributors from this PR are not listed in the metadata files:
Next steps:
|
|
Instead of .mailmap, maybe we should use an AUTHORS or CONTRIBUTORS file? |
Contributor
Author
authors and contributors should be referenced in codemeta.json and citation.cff rather than non-structured AUTHORS or CONTRIBUTORS files in my opinion .mailmap follows a specific structure that allows mapping different identities of the same person to make sure all code contributors are in these files |
Member
|
I agree with @vuillaut! This is ready for merging right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Check makes sure all code contributors are added to
CITATION.cffandcodemeta.jsonby commenting in PRs when new contributors make a PR in the repository (see ⬇️ )