fix(ocpp16): Security events for invalid CP and CPMS certificates #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlitre
changed the title
hikinggrass
approved these changes
May 16, 2025
Make sure we only send security events on failed connection attempts for invalid CPMS certificate. We also changed it so that we send invalid security event for the charge point certificate when the certificate signed response is not correct. Signed-off-by: Martin Litre <[email protected]>
mlitre
force-pushed
the
fix/improve-sec-events-for-certs
branch
from
1d00d9e to
3018cdc
Compare
Pietfried
pushed a commit
that referenced
this pull request
Nov 19, 2025
…1061) (#14) Make sure we only send security events on failed connection attempts for invalid CPMS certificate. We also changed it so that we send invalid security event for the charge point certificate when the certificate signed response is not correct. Signed-off-by: Martin Litre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we only send security events on failed connection attempts for invalid CPMS certificate. We also changed it so that we send invalid security event for the charge point certificate when the certificate signed response is not correct.
Describe your changes
We force or not the sending of certain events using the function parameters.
Issue ticket number and link
Checklist before requesting a review