Fix json exceptions being thrown during handling of invalid messages #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When certain malformed messages that during parsing result in a json exceptions are reported to the CSMS it was observed that secondary parsing exceptions can occur when the error message is sent to the CSMS as part of a CallError as well as when the incoming message in re-serialized in the security event to be sent. This fixes #1104 by catching the secondary exception thrown during error message generation, and by not sending a truncated version of the problematic message but the error message instead. Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
requested review from
Pietfried,
marcemmers and
mlitre
as code owners
Pietfried
requested changes
Jul 11, 2025
Contributor
Pietfried
left a comment
Pietfried
left a comment
There was a problem hiding this comment.
lgtm for ocpp2, it looks like we could have similar issues for ocpp1.6. Can you apply these changes to ocpp1.6, too?
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Pietfried
approved these changes
Jul 11, 2025
hikinggrass
deleted the
bugfix/json-exception-during-malformed-message-handling
branch
stephenredhat
pushed a commit
to stephenredhat/libocpp
that referenced
this pull request
Aug 11, 2025
…Verest#1107) * Fix json exceptions being thrown during handling of invalid messages When certain malformed messages that during parsing result in a json exceptions are reported to the CSMS it was observed that secondary parsing exceptions can occur when the error message is sent to the CSMS as part of a CallError as well as when the incoming message in re-serialized in the security event to be sent. This fixes EVerest#1104 by catching the secondary exception thrown during error message generation, and by not sending a truncated version of the problematic message but the error message instead. * Handle json errors in 1.6 message_callback similarly to 2.x code --------- Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certain malformed messages that during parsing result in a json exceptions are reported to the CSMS it was observed that secondary parsing exceptions can occur when the error message is sent to the CSMS as part of a CallError as well as when the incoming message in re-serialized in the security event to be sent.
This fixes #1104 by catching the secondary exception thrown during error message generation, and by not sending a truncated version of the problematic message but the error message instead.
Describe your changes
Issue ticket number and link
Checklist before requesting a review