fix(v21): Fix V2XChargingCtrlr variables #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlitre
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
mlitre
force-pushed
the
fix/make-v2x-component-evse-specific
branch
from
97cba5d to
de214a2
Compare
This was referenced Jul 24, 2025
Pietfried
approved these changes
Aug 1, 2025
Contributor
Pietfried
left a comment
Pietfried
left a comment
There was a problem hiding this comment.
lgtm, see two comments in line, leaving it up to you to apply
mlitre
force-pushed
the
fix/make-v2x-component-evse-specific
branch
2 times, most recently
from
f8b0593 to
91b4830
Compare
Signed-off-by: Martin Litre <[email protected]>
mlitre
force-pushed
the
fix/make-v2x-component-evse-specific
branch
from
91b4830 to
cae4a71
Compare
Pietfried
approved these changes
Aug 6, 2025
stephenredhat
pushed a commit
to stephenredhat/libocpp
that referenced
this pull request
Aug 11, 2025
Signed-off-by: Martin Litre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
V2X variables were set globally when they were supposed to be evse specific.
Issue ticket number and link
Checklist before requesting a review