Add pinch valve support#47
Merged
EdgarJRobles merged 2 commits intoEdgarJRobles:masterfrom Apr 21, 2026
Merged
Conversation
0c0529a to
db4829b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Valve_pinch_manual_generic.csvtable so manual pinch valves appear in the existing valve insertion form.VTypecontainingpinch.Catalog source and mapping
L (Steel)-> QuetzalHeightface-to-face valve length.D-> QuetzalODBodysizing hint for the body/flange diameter.Dg-> QuetzalIDbore diameter.Kvis set to 0 because the source catalog page does not publish flow coefficients.Catalog URL:
Validation
python3 -m py_compile pFeatures.py pCmd.py pForms.py dodoDialogs.pyPSizevalues are unique, dimensions are positive,Kvis non-negative, and everyVTypedispatches to the pinch renderer.Notes
origin/masterand does not depend on the other open valve PRs.freecadcmd/FreeCADCmdis not installed.