fix(logger): use source maps for error stack traces in browser pretty logger#6093
Open
luchersou wants to merge 1 commit intoEffect-TS:mainfrom
Open
fix(logger): use source maps for error stack traces in browser pretty logger#6093luchersou wants to merge 1 commit intoEffect-TS:mainfrom
luchersou wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6090
Problem
The
prettyLoggerBrowserwas passing the error as a string toconsole.errorviaCause.pretty(...), which causes the browser to lose the reference to the originalErrorobject and therefore can't resolve source maps.Solution
Pass the actual
Errorobjects alongside the formatted string usingCause.prettyErrors(cause), so the browser DevTools can resolve source maps correctly.Before
After
Note
The current output shows both the formatted string from
Cause.prettyand the_PrettyErrorobjects, which results in the stack trace appearing twice.I'm open to feedback on the preferred approach:
Errorobjects — cleaner output, similar to the workaround shown in the issueHappy to adjust based on maintainer preference!