This repository was archived by the owner on Nov 7, 2024. It is now read-only.
Add favicon when opening the preview in browser#239
Merged
Enter-tainer merged 5 commits intoEnter-tainer:mainfrom Feb 3, 2024
Parsifa1:main
Merged
Add favicon when opening the preview in browser#239Enter-tainer merged 5 commits intoEnter-tainer:mainfrom Parsifa1:main
Enter-tainer merged 5 commits intoEnter-tainer:mainfrom
Parsifa1:main
Conversation
Owner
|
The new icon LGTM. did you test it locally and see if it works or not? |
Owner
Collaborator
We perhaps must bundle it inside of the frontend like that: <link rel="icon" type="image/svg+xml" href="data:image/svg+xml,LOVELY_SVG_FAVICON_HERE" />This should ensure the frontend html to be a single file again. |
Collaborator
|
We may use https://cloudconvert.com/svg-to-ico for frontend icon. |
Contributor
Author
Contributor
Author
Enter-tainer
reviewed
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




add an favicon for the localhost website for typst-preview.