Skip to content
This repository was archived by the owner on Nov 7, 2024. It is now read-only.

Add favicon when opening the preview in browser#239

Merged
Enter-tainer merged 5 commits intoEnter-tainer:mainfrom
Parsifa1:main
Feb 3, 2024
Merged

Add favicon when opening the preview in browser#239
Enter-tainer merged 5 commits intoEnter-tainer:mainfrom
Parsifa1:main

Conversation

@Parsifa1
Copy link
Contributor

add an favicon for the localhost website for typst-preview.

@Enter-tainer
Copy link
Owner

The new icon LGTM. did you test it locally and see if it works or not?

@Enter-tainer
Copy link
Owner

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

@Myriad-Dreamin
Copy link
Collaborator

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

We perhaps must bundle it inside of the frontend like that:

<link rel="icon" type="image/svg+xml" href="data:image/svg+xml,LOVELY_SVG_FAVICON_HERE" />

This should ensure the frontend html to be a single file again.

@Myriad-Dreamin
Copy link
Collaborator

We may use https://cloudconvert.com/svg-to-ico for frontend icon.
And https://cloudconvert.com/svg-to-png for extension icon. Constraints for rendering SVG images.

@Parsifa1
Copy link
Contributor Author

Parsifa1 commented Feb 3, 2024

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

sorry, i will try and do some test stuff

@Parsifa1
Copy link
Contributor Author

Parsifa1 commented Feb 3, 2024

image

Done.

Copy link
Owner

@Enter-tainer Enter-tainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enter-tainer Enter-tainer enabled auto-merge (squash) February 3, 2024 14:27
@Enter-tainer Enter-tainer merged commit 0fdbec7 into Enter-tainer:main Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants