Merged
Conversation
added 11 commits
May 4, 2021 08:50
serverless-cloudfront-invalidate
… react-scripts issue - babel-loader resolves to 8.0.1
joshmfranklin
approved these changes
May 4, 2021
Contributor
joshmfranklin
left a comment
There was a problem hiding this comment.
I was able to get the app and storybook up and running and all tests passing. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
babel-loaderversions with storybook. To resolve I manually pinned yarn.lock a level down for now. There is a documented bug in CRA and storybook for this.BUILD_PATHbehavior is something we may want to take advantage of one dayyarn auditandyarn upgradefor any packages I could to try and clear out more dependabot errors.Related issues
This is tech maintenance
Testing guidance