Skip to content

fix: include files if they end with .jl#377

Merged
wsmoses merged 1 commit intomainfrom
ap/safe_include
Dec 14, 2024
Merged

fix: include files if they end with .jl#377
wsmoses merged 1 commit intomainfrom
ap/safe_include

Conversation

@avik-pal
Copy link
Copy Markdown
Collaborator

https://github.com/LuxDL/Lux.jl/actions/runs/12326671368/job/34407753923?pr=1133#step:7:61 lol look me a few days to figure out what was happening. If coverage is enabled we have .cov files generated which will screw up the import of the file.

@avik-pal avik-pal requested a review from mofeing December 14, 2024 04:14
@mofeing
Copy link
Copy Markdown
Collaborator

mofeing commented Dec 14, 2024

Ahhh that's why #353 was failing!! thanks @avik-pal

cc @glou-nes

@wsmoses wsmoses merged commit 73899f5 into main Dec 14, 2024
@wsmoses wsmoses deleted the ap/safe_include branch December 14, 2024 09:28
jumerckx added a commit to jumerckx/Reactant.jl that referenced this pull request Dec 16, 2024
commit 65e9976
Author: William Moses <gh@wsmoses.com>
Date:   Sat Dec 14 14:05:03 2024 -0600

    Interp2 (EnzymeAD#365)

    * WIP: kernels

    * more files

    * fix

    * wip

    * wqtmp

    * wip

    * inc

    * continuing

    * wip

    * more work

    * inf rec

    * fix

    * overload working

    * continuing

    * continuing

    * push

    * fix `call_with_reactant_generator` for Julia 1.11 (EnzymeAD#359)

    * conversion

    * continuing

    * Cleanup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * Delete test/cuda.jl

    * fixup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * fix apply

    * indep of change

    * minor fix in name

    * Update utils.jl

    * Interp take 2

    * continuing adentures

    * delcode

    * fix

    * tmp

    * make

    * fix

    * cleanup

    * continuing

    * more working

    * further simplify

    * fx

    * more improvements

    * minus show

    * less prints

    * even fewer

    * confusion

    * tmp

    * force clean

    * force oc

    * clean

    * Rewrite

    * fixup

    * fix

    * fix

    * fix

    * fixup

    * fix

    * wip

    * safe prints

    * fix

    * fix

    * stackoverflow

    * cleanup

    * dyindex

    * rt

    * continue

    * clean

    * fix

    * fix

    * fix

    * fix

    * fixup

    * fix

    * fix

    * capture oc

    * compile perf

    * v1.11 fix

    * other way 'round

    * formatting

    ---------

    Co-authored-by: William Moses <wsmoses@cyclops.juliacomputing.io>
    Co-authored-by: jumerckx <31353884+jumerckx@users.noreply.github.com>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: jumerckx <julesmerckx12@gmail.com>

commit 73899f5
Author: Avik Pal <avikpal@mit.edu>
Date:   Sat Dec 14 14:58:47 2024 +0530

    fix: include files if they end with .jl (EnzymeAD#377)

commit 9f96c09
Author: Sergio Sánchez Ramírez <15837247+mofeing@users.noreply.github.com>
Date:   Fri Dec 13 23:12:43 2024 +0100

    Run CI on aarch64 (EnzymeAD#350)

    * Run CI on aarch64

    * use julia pipeline for aarch64-linux

    * fix var

    * exclude aarch64-linux jobs from github ci

commit b56e661
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 13 08:58:51 2024 +0530

    chore: format code (EnzymeAD#371)

    Co-authored-by: mofeing <15837247+mofeing@users.noreply.github.com>

commit 311498b
Author: Anton Oresten <antonoresten@gmail.com>
Date:   Thu Dec 12 05:41:39 2024 +0100

    feat: define outer `repeat` method for `TracedRArray` (EnzymeAD#361)

    * Add repeat method

    * Add repeat tests

    * Update test/basic.jl

    * Update src/TracedRArray.jl

commit 8b90501
Author: Avik Pal <avikpal@mit.edu>
Date:   Thu Dec 12 10:11:00 2024 +0530

    fix: ensure printing of wrapped ConcreteRArrays goes through our show (EnzymeAD#367)

    * fix: ensure printing of wrapped ConcreteRArrays goes through our show

    * fix: allow wrapped arrays in mapreduce

commit ea97be3
Author: Sergio Sánchez Ramírez <sergio.sanchez.ramirez+git@bsc.es>
Date:   Wed Dec 11 22:02:14 2024 +0100

    Ignore versioned manifests
jumerckx added a commit to jumerckx/Reactant.jl that referenced this pull request Dec 16, 2024
commit 65e9976
Author: William Moses <gh@wsmoses.com>
Date:   Sat Dec 14 14:05:03 2024 -0600

    Interp2 (EnzymeAD#365)

    * WIP: kernels

    * more files

    * fix

    * wip

    * wqtmp

    * wip

    * inc

    * continuing

    * wip

    * more work

    * inf rec

    * fix

    * overload working

    * continuing

    * continuing

    * push

    * fix `call_with_reactant_generator` for Julia 1.11 (EnzymeAD#359)

    * conversion

    * continuing

    * Cleanup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * Delete test/cuda.jl

    * fixup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * fix apply

    * indep of change

    * minor fix in name

    * Update utils.jl

    * Interp take 2

    * continuing adentures

    * delcode

    * fix

    * tmp

    * make

    * fix

    * cleanup

    * continuing

    * more working

    * further simplify

    * fx

    * more improvements

    * minus show

    * less prints

    * even fewer

    * confusion

    * tmp

    * force clean

    * force oc

    * clean

    * Rewrite

    * fixup

    * fix

    * fix

    * fix

    * fixup

    * fix

    * wip

    * safe prints

    * fix

    * fix

    * stackoverflow

    * cleanup

    * dyindex

    * rt

    * continue

    * clean

    * fix

    * fix

    * fix

    * fix

    * fixup

    * fix

    * fix

    * capture oc

    * compile perf

    * v1.11 fix

    * other way 'round

    * formatting

    ---------

    Co-authored-by: William Moses <wsmoses@cyclops.juliacomputing.io>
    Co-authored-by: jumerckx <31353884+jumerckx@users.noreply.github.com>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: jumerckx <julesmerckx12@gmail.com>

commit 73899f5
Author: Avik Pal <avikpal@mit.edu>
Date:   Sat Dec 14 14:58:47 2024 +0530

    fix: include files if they end with .jl (EnzymeAD#377)

commit 9f96c09
Author: Sergio Sánchez Ramírez <15837247+mofeing@users.noreply.github.com>
Date:   Fri Dec 13 23:12:43 2024 +0100

    Run CI on aarch64 (EnzymeAD#350)

    * Run CI on aarch64

    * use julia pipeline for aarch64-linux

    * fix var

    * exclude aarch64-linux jobs from github ci

commit b56e661
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 13 08:58:51 2024 +0530

    chore: format code (EnzymeAD#371)

    Co-authored-by: mofeing <15837247+mofeing@users.noreply.github.com>

commit 311498b
Author: Anton Oresten <antonoresten@gmail.com>
Date:   Thu Dec 12 05:41:39 2024 +0100

    feat: define outer `repeat` method for `TracedRArray` (EnzymeAD#361)

    * Add repeat method

    * Add repeat tests

    * Update test/basic.jl

    * Update src/TracedRArray.jl

commit 8b90501
Author: Avik Pal <avikpal@mit.edu>
Date:   Thu Dec 12 10:11:00 2024 +0530

    fix: ensure printing of wrapped ConcreteRArrays goes through our show (EnzymeAD#367)

    * fix: ensure printing of wrapped ConcreteRArrays goes through our show

    * fix: allow wrapped arrays in mapreduce

commit ea97be3
Author: Sergio Sánchez Ramírez <sergio.sanchez.ramirez+git@bsc.es>
Date:   Wed Dec 11 22:02:14 2024 +0100

    Ignore versioned manifests
@avik-pal avik-pal restored the ap/safe_include branch April 18, 2026 12:46
@giordano giordano deleted the ap/safe_include branch April 18, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants