Make the logo show on Github. #1114
Open
patrickmineault wants to merge 2 commits intoEpistimio:developfrom
Open
Make the logo show on Github. #1114patrickmineault wants to merge 2 commits intoEpistimio:developfrom
patrickmineault wants to merge 2 commits intoEpistimio:developfrom
Conversation
Fix the logo
Should work in both readthedocs and on Github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The logo currently doesn't show on Github but works on readthedocs. This PR fixes that and makes it show on both platforms by using an absolute URL.
Changes
Changes a relative to an absolute reference to a PNG. This is a purely cosmetic change that allows one to see the Orion logo in its full glory on Github.
Before 😿
After 😸