Merged
Conversation
In python 3.7, the Generic class has a metaclass (GenericMeta or something similar), and inspect.signature(type(self)) would give the signature of the metaclass's `__call__` method, instead of the signature of the __init__ of the class. Also fixed a bug whereby it would include "self" and "args" from *args into the param names. This wasn't causing issues because we check if `self` has an attribute with the given name before including it in the configuration. Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
lebrice
changed the title
bouthilx
approved these changes
Jun 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug when inferring the param names (configuration keys) for algorithms that inherit from
typing.Generic, in python 3.7.In python 3.7, the Generic class has a metaclass (GenericMeta or something similar), and inspect.signature(type(self)) would give
the signature of the metaclass's
__call__method, instead of the signature of the init of the class.Also fixed a bug whereby it would include "self" and "args" from *args into the param names.
This wasn't causing issues because we check if
selfhas an attribute with the given name before including it in the configuration.Signed-off-by: Fabrice Normandin fabrice.normandin@gmail.com