Skip to content

[dashboard/db page] DIsplay parameters in separated flattened columns after ID column#961

Merged
bouthilx merged 1 commit intoEpistimio:developfrom
notoraptor:db-flatten-params
Jul 6, 2022
Merged

[dashboard/db page] DIsplay parameters in separated flattened columns after ID column#961
bouthilx merged 1 commit intoEpistimio:developfrom
notoraptor:db-flatten-params

Conversation

@notoraptor
Copy link
Copy Markdown
Collaborator

Description

Hi @bouthilx , this is a PR to display parameters in separated columns with flattened parameter names.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Further comments

Still don't know what to do with testing. I added a preliminary test for flatten function, but not for changes in trials table.

Copy link
Copy Markdown
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouthilx bouthilx merged commit 11eb0b7 into Epistimio:develop Jul 6, 2022
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Jul 6, 2022
@notoraptor notoraptor deleted the db-flatten-params branch July 7, 2022 18:53
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants