Skip to content

[dashboard/experiments/navbar] Remove (x) icon on experiment menu and rely on highlight only#970

Merged
bouthilx merged 3 commits intoEpistimio:developfrom
notoraptor:remove-experiment-x-icon
Jul 27, 2022
Merged

[dashboard/experiments/navbar] Remove (x) icon on experiment menu and rely on highlight only#970
bouthilx merged 3 commits intoEpistimio:developfrom
notoraptor:remove-experiment-x-icon

Conversation

@notoraptor
Copy link
Copy Markdown
Collaborator

Description

Hi @bouthilx ! This is a PR that removes (x) button in experiments navbar.

Changes

  • Remove (x) button in experiments navbar
  • Select experiment when we click on row (as usual), and deselect experiment if we re-click on same row (instead of x button)
  • Selected experiment row is highlighted with gray background and bold font
  • I also updated current tests in this PR, although CI will still not run here

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Jul 27, 2022
@bouthilx bouthilx merged commit 482f670 into Epistimio:develop Jul 27, 2022
@notoraptor notoraptor deleted the remove-experiment-x-icon branch August 1, 2022 15:51
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants