Skip to content

feat: add scaling mode stretch#110

Merged
jasongdove merged 2 commits intomainfrom
feat/scaling-mode-stretch
Apr 29, 2026
Merged

feat: add scaling mode stretch#110
jasongdove merged 2 commits intomainfrom
feat/scaling-mode-stretch

Conversation

@jasongdove
Copy link
Copy Markdown
Contributor

Resolves #70

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a ScalingMode configuration, allowing users to choose between ScaleAndPad and Stretch during video normalization. The changes include updates to the configuration schema, the FFmpeg pipeline logic, and hardware acceleration modules to support these modes. A review comment identifies a logic error where scaling is skipped if dimensions match, noting that anamorphic content still requires scaling to normalize the sample aspect ratio.

Comment thread crates/ffpipeline/src/video_filter.rs Outdated
@jasongdove jasongdove merged commit 3868182 into main Apr 29, 2026
8 checks passed
@jasongdove jasongdove deleted the feat/scaling-mode-stretch branch April 29, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaling behavior STRETCH

1 participant