[New] Set atmosphere effect in scene #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
des12437
requested review from
a team,
CalebRas and
zkline101
and removed request for
a team
CalebRas
reviewed
Jun 4, 2025
Collaborator
CalebRas
left a comment
CalebRas
left a comment
There was a problem hiding this comment.
Looks great! Just some suggestions:
Shared/Samples/Set atmosphere effect in scene/SetAtmosphereEffectInSceneView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Set atmosphere effect in scene/SetAtmosphereEffectInSceneView.swift
Outdated
Show resolved
Hide resolved
CalebRas
approved these changes
Jun 4, 2025
zkline101
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Set atmosphere effect in sceneinScenescategory.URL to README: URL
Linked Issue(s)
swift/issues/6944How To Test
Open the sample and change the atmosphere effect.
Screenshots