-
Notifications
You must be signed in to change notification settings - Fork 12
[New] Query table statistics group and sort #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
des12437
previously approved these changes
Jun 6, 2025
Contributor
des12437
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
philium
reviewed
Jun 9, 2025
...mples/Query table statistics group and sort/QueryTableStatisticsGroupAndSortView.Views.swift
Outdated
Show resolved
Hide resolved
...mples/Query table statistics group and sort/QueryTableStatisticsGroupAndSortView.Views.swift
Outdated
Show resolved
Hide resolved
...mples/Query table statistics group and sort/QueryTableStatisticsGroupAndSortView.Views.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Ridgeway <[email protected]>
philium
approved these changes
Jun 9, 2025
des12437
approved these changes
Jun 9, 2025
Collaborator
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Query table statistics group and sortinSearch and Querycategory.URL to README: Query table statistics group and sort
Linked Issue(s)
swift/issues/6939How To Test
Screenshots
To Discuss
The design specifies having some default statistic definitions and fields, but I didn't add any to try to keep this sample as small as possible and to match the iOS implementation. Let me know if you have any opinions either way, though.