[New] Show geodesic sector and ellipse #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswebb09
changed the title
philium
reviewed
Jul 1, 2025
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show geodesic sector and ellipse/show-geodesic-sector-and-ellipse.png
Show resolved
Hide resolved
zkline101
reviewed
Jul 2, 2025
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachary Kline <[email protected]>
Contributor
|
Also, I could see it being helpful to add a banner like in other Samples that tell the user how to get started. For example, telling them to tap on the map. |
Collaborator
Author
Oh gotcha, okay, I'll add in an overlay. |
Collaborator
Author
|
Disappears when user taps
|
zkline101
previously approved these changes
Jul 2, 2025
philium
reviewed
Jul 2, 2025
Shared/Samples/Show geodesic sector and ellipse/ShowGeodesicSectorAndEllipseView.swift
Outdated
Show resolved
Hide resolved
…ctorAndEllipseView.swift Co-authored-by: Philip Ridgeway <[email protected]>
zkline101
approved these changes
Jul 2, 2025
philium
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Show geodesic sector and ellipseinVisualizationcategory.Linked Issue(s)
swift/issues/6975Screenshots