Skip to content

Conversation

@yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Jul 8, 2025

Description

This PR fixes a deprecation warning in FeatureFormView sample.

Linked Issue(s)

How To Test

Run the sample and ensure…

  • UI still works on Mac Catalyst
  • The form is presented as normal/same behavior as the floating panel

Screenshots

Before After
edit-features-using-feature-forms edit-features-using-feature-forms

To Discuss

@yo1995 yo1995 requested review from CalebRas and dfeinzimer July 8, 2025 17:10
@yo1995 yo1995 self-assigned this Jul 8, 2025
@yo1995 yo1995 marked this pull request as ready for review July 8, 2025 17:13
@dfeinzimer
Copy link
Contributor

This can probably also close Swift 7029.

@dfeinzimer
Copy link
Contributor

After the change we can see that the title of the form "Feature Form Places" has an additional "X" button to its right. Is it expected? 🤔

Yes, expected, however I'd say the header now looks confusing with the close button, discard button and submit button. 🤔 I think the discard button can go away entirely, as that's built into the form now. As for the submit button, we might want to look at other options for where to place it.

Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the new built-in close button, the selected feature stays selected.

I think the sample will need some more structural changes given the new save and discard functionality built into the component.

What if we got rid of featureFormToolbar entirely and placed the apply edits button into a toolbar item only visible after the form has been closed?

@yo1995
Copy link
Collaborator Author

yo1995 commented Jul 8, 2025

Thanks, I'll toy with the UI a bit and see what I can get… back into draft

@yo1995 yo1995 marked this pull request as draft July 8, 2025 18:26
@yo1995 yo1995 marked this pull request as ready for review July 8, 2025 23:47
@yo1995 yo1995 requested a review from dfeinzimer July 8, 2025 23:51
@yo1995 yo1995 requested a review from CalebRas July 9, 2025 20:31
CalebRas
CalebRas previously approved these changes Jul 9, 2025
@yo1995 yo1995 requested review from dfeinzimer and removed request for dfeinzimer July 10, 2025 15:24
@yo1995 yo1995 requested review from CalebRas and dfeinzimer July 10, 2025 16:46
Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yo1995
Copy link
Collaborator Author

yo1995 commented Jul 10, 2025

Thanks. I'll update the sample design accordingly.

@yo1995 yo1995 merged commit 1d59d73 into v.next Jul 10, 2025
1 check passed
@yo1995 yo1995 deleted the Ting/FeatureFormDeprecation branch July 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants