-
Notifications
You must be signed in to change notification settings - Fork 12
[Update] Address FeatureFormView deprecation warning
#657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This can probably also close Swift 7029. |
Yes, expected, however I'd say the header now looks confusing with the close button, discard button and submit button. 🤔 I think the discard button can go away entirely, as that's built into the form now. As for the submit button, we might want to look at other options for where to place it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the new built-in close button, the selected feature stays selected.
I think the sample will need some more structural changes given the new save and discard functionality built into the component.
What if we got rid of featureFormToolbar entirely and placed the apply edits button into a toolbar item only visible after the form has been closed?
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Outdated
Show resolved
Hide resolved
|
Thanks, I'll toy with the UI a bit and see what I can get… back into draft |
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Show resolved
Hide resolved
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Show resolved
Hide resolved
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Edit features using feature forms/EditFeaturesUsingFeatureFormsView.swift
Outdated
Show resolved
Hide resolved
dfeinzimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks. I'll update the sample design accordingly. |
Description
This PR fixes a deprecation warning in
FeatureFormViewsample.Linked Issue(s)
FeatureFormView- Revise init changes, maintain deprecated init behavior arcgis-maps-sdk-swift-toolkit#1201swift/issues/7029How To Test
Run the sample and ensure…
Screenshots
To Discuss
FeatureFormView- Revise init changes, maintain deprecated init behavior arcgis-maps-sdk-swift-toolkit#1201 (comment)))