-
Notifications
You must be signed in to change notification settings - Fork 12
[New] Show shapefile metadata #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
…ew.swift Co-authored-by: Copilot <[email protected]>
mhdostal
requested changes
Jul 24, 2025
Member
mhdostal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of minor things.
Shared/Samples/Show shapefile metadata/ShowShapefileMetadataView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show shapefile metadata/ShowShapefileMetadataView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show shapefile metadata/ShowShapefileMetadataView.swift
Outdated
Show resolved
Hide resolved
mhdostal
approved these changes
Jul 25, 2025
Member
mhdostal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work!
pgruenler
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Show shapefile metadatainVisualizationcategory.Linked Issue(s)
swift/issues/7109How To Test
Load map and wait for shape file to render. Tap button and see the information popup.
Screenshots