[Fix] Use LocalizedError.errorDescription in error alert
#726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebRas
requested review from
rolson and
yo1995
and removed request for
a team
yo1995
approved these changes
Nov 18, 2025
des12437
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#557 updated the
View.errorAlert(presentingError:)message to display an error's type instead ofError.localizedDescriptionsince the former generally is more descriptive for ArcGIS errors. This caused the alert to be less descriptive for the samples that make use of customLocalizedErrors. This PR fixes that by usingLocalizedError.errorDescriptionwhen possible.How To Test
Open
Show device location using indoor positioning(which currently throws an error upon opening for me), and ensure the error's description is displayed.Screenshots