[Fix] Download Offline Resources bugs #734
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues with the Download Offline Resources page:
GaugeProgressViewStyle.NSBundleResourceRequestbug that causes presentations to hang when downloading resources, even when downloading on a background thread. I could not find a way to work around this, so I removed the alert, which was confusing anyway. I updated the "Done" button show "Cancel" when there are in-progress downloads instead.ProgressViewaccessed a dellocatedProgressinstance. To work around this, I changedOnDemandResource.progressto an object that gets manually updated fromrequest.progressduring downloading. 7c6b39bLinked Issue(s)
swift/issues/7572How To Test
Ensure the above-mentioned issues are no longer present.
Embed Asset Packs In Product BundletoNounder the Target Build Settings.Screenshots