Skip to content

Conversation

@Traben-0
Copy link

@Traben-0 Traben-0 commented Nov 9, 2025

I am unable to test via local maven due to build failures on windows due to it generating directories with ":"

If there is some other testing method @Johni0702 i'd like to learn it / give it a go before we merge, also just to make sure there isnt anything else affecting this linear issue that the reporter may have missed.

Linear: EM-3472

@Traben-0 Traben-0 requested a review from Johni0702 November 9, 2025 11:39
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Test Results

16 files  ±0  16 suites  ±0   11m 44s ⏱️ -1s
95 tests ±0  95 ✅ ±0  0 💤 ±0  0 ❌ ±0 
99 runs  ±0  99 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d1e5bf8. ± Comparison against base commit d75286a.

♻️ This comment has been updated with latest results.

clazz.getDeclaredField("adapterMap");
return clazz;
} catch (NoSuchFieldException ignored) {
clazz = clazz.getSuperclass();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Instead of simply dropping these, we could accumulate them and then attach them as the cause to the final exception we throw. That way it'll hopefully be clearer which classes it tried and why it rejected each one.

Exception ex;
while (...) {
   try {
        ...
   } catch (NoSuchFieldException e) {
        if (ex == null) ex = e;
        else ex.addSuppressed(e);
        ...
   }
}
throw new ClassNotFoundException("Could not find the FabricLoader implementation class", ex);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants