Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Euka! Hopefully not a huge deal to contribute something small like this. The way the Lightning Shield flashes underwater palettes in AIR didn't really feel right to me, especially with extended character palettes not being affected by it in its current behavior.
I did a little bit of a hacky method to check the Lightning Shield's flash timer to run new palette code in a different spot, but it shouldn't cause issues I hope. Also would, as far as I know, fix potential issues that have existed in Genesis S3K (I'm unsure if any of it was fixed with AIR) where the palette remains white underwater with unintended conditions being met.