fix: timezone parsing in str.to_datetime#4241
Merged
universalmind303 merged 7 commits intomainfrom Apr 26, 2025
Merged
Conversation
The commit adds explicit offset detection when parsing datetime strings to ensure timezone-aware and naive datetimes are handled correctly. Fix datetime parsing to check timezone offset first The change is self-explanatory from the subject line and the logic change is straightforward, so no body is needed.
The changes improve handling of timezone offsets in datetime parsing: - Convert dates with timezone offsets to UTC when no timezone specified - Add helper to detect if format string contains offset characters - Update tests to reflect UTC timezone coercion behavior
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4241 +/- ##
==========================================
+ Coverage 78.46% 78.47% +0.01%
==========================================
Files 798 798
Lines 105192 105279 +87
==========================================
+ Hits 82536 82616 +80
- Misses 22656 22663 +7
🚀 New features to boost your workflow:
|
colin-ho
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
changes the
to_datetimekernel to try parsing with a timezone offset first as you can have a valid string with a timezone, but that would previously fail when trying to parse as seen in #4220Related Issues
closes #4220
Checklist
docs/mkdocs.ymlnavigation