feat(cache): version-aware response cache keys + cleanup#1217
Merged
Conversation
…n isolation - Add get_lmms_eval_cache_version() utility: git commit hash for dev installs, PyPI version for pip installs - Include eval_version in cache key payload (schema v2 -> v3) - Store eval_version in SQLite meta table, warn on version mismatch - Add eval_version to JSONL audit log records - Remove unused .claude-plugin/marketplace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval_version(git commit for dev installs, PyPI version for pip installs), preventing stale cache reuse across lmms-eval upgrades. Schema bumped v2 -> v3.eval_versionfield added to JSONL audit records for traceability..claude-plugin/marketplace.json.Changes
lmms_eval/utils.pyget_lmms_eval_cache_version()— git commit hash for dev, PyPI version for piplmms_eval/caching/response_cache.pyeval_versionin cache key / meta table / audit log / constructorlmms_eval/evaluator.pyeval_versiontoResponseCache.claude-plugin/marketplace.jsonWhy
After upgrading lmms-eval, cached responses from a previous version could silently be reused even if the evaluation logic changed. Including the eval version in the cache key ensures automatic invalidation — old entries simply won't match, with zero risk of stale results.