Skip to content

Remove hardcoded single live-harness scenario defaults#795

Merged
PrzemyslawKlys merged 3 commits intomasterfrom
feat/chat-live-harness-no-hardcoded-default-20260225
Feb 25, 2026
Merged

Remove hardcoded single live-harness scenario defaults#795
PrzemyslawKlys merged 3 commits intomasterfrom
feat/chat-live-harness-no-hardcoded-default-20260225

Conversation

@PrzemyslawKlys
Copy link
Member

Summary:\n- remove AD-specific default scenario path from single live harness\n- add tag-driven auto-selection to Build/Run-ChatLiveConversation.ps1 when ScenarioFile is omitted\n- update preflight live-smoke mode to forward auto-selection defaults (filter + tags)\n- refresh InternalDocs roadmap snapshot with merged WS1 replay-mismatch hardening status\n\nValidation:\n- dotnet build IntelligenceX.sln -c Release\n- dotnet test IntelligenceX.sln -c Release\n- dotnet ./IntelligenceX.Tests/bin/Release/net8.0/IntelligenceX.Tests.dll\n- dotnet ./IntelligenceX.Tests/bin/Release/net10.0/IntelligenceX.Tests.dll\n- PowerShell parser validation for updated scripts

@intelligencex-review
Copy link

intelligencex-review bot commented Feb 25, 2026

IntelligenceX Review

Reviewing PR #795: Remove hardcoded single live-harness scenario defaults
Reviewed commit: 87b769c

Merge blockers: items in Todo List ✅ and Critical Issues ⚠️ sections (if present). Other Issues 🧯 are suggestions.

Review context truncated: 1 patch trimmed to 4000 chars. Impact: review covers only included diff context; issues outside it may be missed. Increase review.maxFiles/review.maxPatchChars for wider coverage.

Summary 📝

This PR is primarily docs/roadmap updates describing the removal of hardcoded AD-only live-harness defaults and the new tag-driven auto-selection behavior. I don’t see merge-blocking correctness or maintainability issues in the provided diff.

Todo List ✅

None.

Other Issues 🧯

  • In IntelligenceX.Chat/README.md, the parameter naming guidance is clear but a bit dense; consider a compact table mapping -ScenarioTags, -Tags, -LiveScenarioTags, -LiveSuiteTags to script(s) that consume them, to reduce misuse risk as options grow.
  • The README now states default auto-selection behavior for preflight (*-10-turn.json + strict,live); ensure this stays synced with script defaults over time (doc drift risk if defaults change later).
  • In InternalDocs/roadmaps/..., status/risk updates look consistent, but this file is carrying operational truth; consider linking each “mostly_done” status to concrete acceptance criteria to keep maintainability of planning artifacts high.

Tests / Coverage 🧪

  • Validation commands listed in PR description are appropriate for this change class (build/test + PowerShell parser checks).
  • Since behavior change is in script defaults/selection semantics, add or confirm script-level tests/assertions around:
    • omitted -ScenarioFile selects first match by filter+tags,
    • quoted CSV tag input is rejected or clearly handled,
    • preflight forwarding behavior when -RunLiveHarness is set without -LiveScenarioFile.

Next Steps 🚀

  1. Merge as-is if script behavior already matches the documented defaults.
  2. Add/verify lightweight script tests for tag parsing and auto-selection to prevent regressions in future default changes.

Static Analysis Policy 🧭

  • Config mode: respect
  • Packs: All Essentials (50)
  • Rules: 108 enabled
  • Rule list display: up to 10 items per section
  • Enabled rules preview: CA2000 (Dispose objects before losing scope), CA1062 (Validate arguments of public methods), SA1600 (Elements should be documented), CA1016 (Mark assemblies with assembly version), CA1018 (Mark attributes with AttributeUsageAttribute), CA1041 (Provide ObsoleteAttribute message), CA1047 (Do not declare protected member in sealed type), CA1050 (Declare types in namespaces), CA1061 (Do not hide base class methods), CA1067 (Override Object.Equals(object) when implementing IEquatable<T>) (truncated)
  • Gate rule IDs: IXTOOL001 (Write-capable tools should use canonical schema helpers)
  • Result files: 2 input patterns, 0 matched, 0 parsed, 0 failed
  • Status: unavailable
  • Rule outcomes: unavailable (no analysis result files matched configured inputs)

Static Analysis 🔎

  • Findings: unavailable (no analysis result files matched configured inputs)

Model & Usage 🤖

  • Model: gpt-5.3-codex
  • Length: medium
  • Mode: hybrid
  • Reasoning: not configured
  • Usage: 5h limit: 100% remaining | weekly limit: 65% remaining | code review weekly limit: 100% remaining | credits: 0

@PrzemyslawKlys
Copy link
Member Author

Addressed the latest IntelligenceX bot blocker items in this PR:

  • clarified -ScenarioTags / -LiveScenarioTags parsing semantics in README (array form vs quoted CSV string)
  • resolved the related review threads

Current merge blocker is now infra-only:

Once the external dependency/workflow blocker is cleared, this PR should be ready to merge.

@PrzemyslawKlys PrzemyslawKlys merged commit 7d419e8 into master Feb 25, 2026
5 of 6 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the feat/chat-live-harness-no-hardcoded-default-20260225 branch February 25, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant