Update mtime on scss target file#122
Open
gpeterso wants to merge 1 commit intoExLibrisGroup:masterfrom
Open
Conversation
Modify the custom-scss task such that it updates the mtime on the target file (css/custom-scss-compiled.css).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the
custom-scsstask so that it updates the mtime on the target file (css/custom-scss-compiled.css).Why is this needed? Normally,
gulp.dest()will simply propagate the source file's mtime to the target file. In this case, the source file isscss/main.scss.Suppose your
main.scssfile contains the following line:If you modify
scss/_variables.scss, thewatch-custom-scsstask will trigger an update tocss/custom-scss-compiled.css). However, the updated file's mtime will remain unchanged because the mtime onscss/main.scsshas not changed. As a result, thewatch-csstask will not know thatcss/custom1.cssneeds to be rebuilt.I'm guessing this is an unintended side-effect of changing the
watch-csstask to use polling instead of filesystem events (f34630e). Simply touching the target file seems like the most straightforward solution.