Add invoice company name and website update system messages #78488

rayane-d · 2025-12-27T00:01:46Z

Explanation of Change

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/568313
PROPOSAL:

Tests

Prerequisites

A workspace
Admin access to the workspace
Go to workspace settings
Make any change that generates a changelog (e.g., rename the workspace) twice to ensure the system messages thread exists
Go to the workspace #admins room
Verify that a system messages thread is created

Test Steps

Navigate to Settings > Workspaces > [Your Workspace] > More features
Enable Invoices
Navigate to Settings > Workspaces > [Your Workspace] > Invoices
Under the Invoicing details settings, add the company name and website
Navigate to the #admins room
Open the system messages thread

Expected Results:

Changelog entries appears in the system messages thread in the #admins room
Message format:
- set the invoice company name to "New company name"
- set the invoice company website to "https://new-company.com"
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Navigate to Settings > Workspaces > [Your Workspace] > Invoices
Under the Invoicing details settings, change the company name and website
Navigate to the #admins room
Open the system messages thread

Expected Results:

Changelog entries appears in the system messages thread in the #admins room
Message format:
- changed the invoice company name to "New company name" (previously "Old company name")
- changed the invoice company website to "https://new-company.com" (previously "https://old-company.com"
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Change logs screenshot:

Recording:

Screen.Recording.2025-12-27.at.11.44.03.PM.mov

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-27T00:01:51Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-12-27T00:12:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.76% <ø> (ø)`
src/libs/OptionsListUtils/index.ts	`73.45% <50.00%> (-0.06%)`	⬇️
src/libs/ReportActionsUtils.ts	`54.14% <80.00%> (+0.15%)`	⬆️
src/libs/ReportNameUtils.ts	`82.45% <50.00%> (-0.61%)`	⬇️
src/libs/ReportUtils.ts	`71.68% <50.00%> (-0.16%)`	⬇️
src/libs/SidebarUtils.ts	`80.20% <50.00%> (-0.25%)`	⬇️
src/pages/home/report/PureReportActionItem.tsx	`52.19% <50.00%> (-0.53%)`	⬇️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.73% <0.00%> (-0.03%)`	⬇️
... and 101 files with indirect coverage changes

rayane-d · 2026-01-02T19:27:23Z

Resolved merge conflicts

deetergp · 2026-01-03T01:43:12Z

@rayane-d This one is still listed as a draft. Is it ready to be reviewed? And it has some manual testing steps, nice!

rayane-d · 2026-01-07T14:30:30Z

This is on hold for these BE PRs:

rayane-d · 2026-01-07T14:47:06Z

I've resolved the merge conflicts in this PR, but it seems there are failing checks

rayane-d · 2026-01-07T15:04:44Z

src/languages/es.ts

+        changedInvoiceCompanyName: ({newValue, oldValue}: {newValue: string; oldValue?: string}) =>
+            oldValue ? `cambió el nombre de la empresa de la factura a "${newValue}" (previamente "${oldValue}")` : `estableció el nombre de la empresa de la factura como "${newValue}"`,
+        changedInvoiceCompanyWebsite: ({newValue, oldValue}: {newValue: string; oldValue?: string}) =>
+            oldValue
+                ? `cambió el sitio web de la empresa de la factura a "${newValue}" (previamente "${oldValue}")`
+                : `estableció el sitio web de la empresa de la factura como "${newValue}"`,


Confirming translation: https://expensify.slack.com/archives/C01GTK53T8Q/p1767798108473649?thread_ts=1767798099.522189&cid=C01GTK53T8Q

deetergp · 2026-01-09T18:28:59Z

@rayane-d That check that is failing is because I haven't filled out the PR Reviewer Checklist yet. Is this ready for review? If it is, please click the "Ready for review" button and take it out of draft mode.

melvin-bot · 2026-01-09T21:33:18Z

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-01-09T21:35:42Z

If this requires C+ review, I can help

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80f78ef808

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-09T21:46:26Z

src/libs/ReportActionsUtils.ts

+function getInvoiceCompanyNameUpdateMessage(translate: LocalizedTranslate, action: ReportAction): string {
+    const {newValue, oldValue} = getOriginalMessage(action as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_INVOICE_COMPANY_NAME>) ?? {};
+
+    if (typeof newValue === 'string' && typeof oldValue === 'string') {
+        return translate('workspaceActions.changedInvoiceCompanyName', {newValue, oldValue});


Localize initial invoice name changes when oldValue is missing

When the invoice company name is set for the first time, the changelog payload typically has a newValue but no oldValue. This helper only localizes when both are strings, so first‑time updates fall back to getReportActionText (server English) and bypass the new translated “set …” message. That means non‑English users will see unlocalized text in the system message, LHN preview, and copied message. The same conditional exists in getInvoiceCompanyWebsiteUpdateMessage below, so first‑time website updates will also be unlocalized.

Useful? React with 👍 / 👎.

Agree with bot. If oldValue is undefined, it will cause regression of not showing set the invoice company name to "${newValue}".

Addressed: 72c27d4

rayane-d · 2026-01-14T12:03:31Z

@situchan I've addressed the review comment and added automated tests 👍

situchan · 2026-01-14T15:50:29Z

I set company name and website but I don't see system messages in thread

Screen.Recording.2026-01-14.at.9.49.25.PM.mov

rayane-d · 2026-01-14T15:51:57Z

@situchan are you able to find them in the debug menu/ API response?

situchan · 2026-01-14T16:03:37Z

Here's video for repro step

Screen.Recording.2026-01-14.at.10.01.02.PM.mov

situchan · 2026-01-14T16:05:15Z

I set company website to google.com but system message not appearing (both optimistic and backend)

Not exist in Onyx data

rayane-d · 2026-01-15T15:47:37Z

@situchan I'm not able to reproduce:

Screen.Recording.2026-01-15.at.4.46.22.PM.mov

rayane-d · 2026-01-15T15:50:50Z

@situchan The issue is that some validation is preventing you from setting the website to google.com. Could you try using another test URL?

situchan · 2026-01-16T14:48:30Z

@situchan The issue is that some validation is preventing you from setting the website to google.com. Could you try using another test URL?

Another URL works. ok we can unblock on this as edge case

situchan · 2026-01-19T10:42:17Z

@rayane-d what is the logic of creating separate thread? I thought all these system messages were in one thread.

Still I am facing optimistic issue. Updated system messages don't appear until online.
This is not yet implemented and out of scope for this PR, right?

Screen.Recording.2026-01-19.at.4.39.11.PM.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 093742fe0a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-19T10:46:14Z

src/libs/ReportActionsUtils.ts

+    const {newValue, oldValue} = getOriginalMessage(action as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_INVOICE_COMPANY_NAME>) ?? {};
+
+    if (typeof newValue === 'string') {
+        return translate('workspaceActions.changedInvoiceCompanyName', {newValue, oldValue: typeof oldValue === 'string' ? oldValue : undefined});
+    }


Add invoice update messages to thread title mapping

These new helpers are used for the report action body/LHN/copy, but thread report titles still come from ReportNameUtils.computeChatThreadReportName/ReportUtils.getReportName, which fall back to getReportActionText for admin rooms. Since UPDATE_INVOICE_COMPANY_NAME/WEBSITE aren’t handled there (unlike other policy change log updates), a thread created from these changelog entries will show the raw backend message (often English and without the new/old values) instead of the localized text you just added. Consider wiring these action types into the report-name mapping so thread titles match the system message.

Useful? React with 👍 / 👎.

Not found issue but do you think we should update OptionsListUtils.getLastMessageTextForReport, ReportNameUtils.computeReportNameBasedOnReportAction and ReportUtils.getReportName as well to support UPDATE_INVOICE_COMPANY_NAME, UPDATE_INVOICE_COMPANY_WEBSITE types?

rayane-d · 2026-01-19T11:06:54Z

@rayane-d what is the logic of creating separate thread? I thought all these system messages were in one thread.

@situchan, The logic is that we only reuse a thread if the last action was within the past 24 hours; otherwise, we create a new thread.

rayane-d · 2026-01-19T11:09:30Z

Still I am facing optimistic issue. Updated system messages don't appear until online. This is not yet implemented and out of scope for this PR, right?

Screen.Recording.2026-01-19.at.4.39.11.PM.mov

These system messages are generated on the backend only; we don't generate optimistic actions for them while offline.

…ils.computeReportNameBasedOnReportAction` and `ReportUtils.getReportName` to support `UPDATE_INVOICE_COMPANY_NAME`, `UPDATE_INVOICE_COMPANY_WEBSITE` types

melvin-bot · 2026-01-19T11:37:43Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #79889.

situchan · 2026-01-19T11:38:00Z

Final @codex review 😄

chatgpt-codex-connector · 2026-01-19T12:06:13Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-19T12:21:06Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

OSBotify · 2026-01-19T20:19:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:41:14Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add invoice company name and website update messages

6ea2396

melvin-bot bot assigned rayane-d Dec 27, 2025

rayane-d added 3 commits December 27, 2025 01:01

add translations

dcb05af

fix translations

e344894

prettier

524c49f

rayane-d changed the title ~~Add invoice company name and website update messages~~ Add invoice company name and website update system messages Dec 27, 2025

rayane-d requested a review from deetergp January 2, 2026 19:24

Merge branch 'main' into invoice-company-name-website-changelog

408232d

rayane-d changed the title ~~Add invoice company name and website update system messages~~ [Hold Auth#18961 Web-E#49961] Add invoice company name and website update system messages Jan 2, 2026

Merge branch 'main' into invoice-company-name-website-changelog

9292816

refactor deprecated translateLocal usage

80f78ef

rayane-d commented Jan 7, 2026

View reviewed changes

rayane-d marked this pull request as ready for review January 9, 2026 21:32

rayane-d requested review from a team as code owners January 9, 2026 21:32

melvin-bot bot requested review from heyjennahay and justinpersaud and removed request for a team January 9, 2026 21:32

rayane-d changed the title ~~[Hold Auth#18961 Web-E#49961] Add invoice company name and website update system messages~~ [Hold Auth#18961 Web-E#49961] [Hold Spanish translation confirmation] Add invoice company name and website update system messages Jan 9, 2026

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

Merge branch 'main' into invoice-company-name-website-changelog

ddcca72

rayane-d requested a review from situchan January 14, 2026 12:02

rayane-d changed the title ~~[Hold Spanish translation confirmation] Add invoice company name and website update system messages~~ Add invoice company name and website update system messages Jan 14, 2026

Merge branch 'main' into invoice-company-name-website-changelog

7065a7e

Merge branch 'main' into invoice-company-name-website-changelog

093742f

chatgpt-codex-connector bot reviewed Jan 19, 2026

View reviewed changes

updated OptionsListUtils.getLastMessageTextForReport, `ReportNameUt…

798e582

…ils.computeReportNameBasedOnReportAction` and `ReportUtils.getReportName` to support `UPDATE_INVOICE_COMPANY_NAME`, `UPDATE_INVOICE_COMPANY_WEBSITE` types

situchan approved these changes Jan 19, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Jan 19, 2026

Payment issue for E/App PR#78488 #79889

Open

deetergp approved these changes Jan 19, 2026

View reviewed changes

deetergp merged commit 1b67648 into Expensify:main Jan 19, 2026
31 of 32 checks passed

rayane-d deleted the invoice-company-name-website-changelog branch January 19, 2026 20:13

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Open

82 tasks

Add invoice company name and website update system messages #78488

Add invoice company name and website update system messages #78488

Conversation

rayane-d commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Prerequisites

Test Steps

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 27, 2025

Uh oh!

codecov bot commented Dec 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rayane-d commented Jan 2, 2026

Uh oh!

deetergp commented Jan 3, 2026

Uh oh!

rayane-d commented Jan 7, 2026

Uh oh!

rayane-d commented Jan 7, 2026

Uh oh!

rayane-d Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

deetergp commented Jan 9, 2026

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

situchan commented Jan 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

rayane-d Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Jan 14, 2026

Uh oh!

situchan commented Jan 14, 2026

Uh oh!

rayane-d commented Jan 14, 2026

Uh oh!

situchan commented Jan 14, 2026

Uh oh!

situchan commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Jan 15, 2026

Uh oh!

rayane-d commented Jan 15, 2026

Uh oh!

situchan commented Jan 16, 2026

Uh oh!

situchan commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rayane-d commented Dec 27, 2025 •

edited

Loading

codecov bot commented Dec 27, 2025 •

edited by github-actions bot

Loading

situchan commented Jan 14, 2026 •

edited

Loading

situchan commented Jan 19, 2026 •

edited

Loading

situchan Jan 19, 2026 •

edited

Loading