Fix: Filter ineligible reports in useOutstandingReports hook#84832
Draft
abzokhattab wants to merge 1 commit intoExpensify:mainfrom
Draft
Fix: Filter ineligible reports in useOutstandingReports hook#84832abzokhattab wants to merge 1 commit intoExpensify:mainfrom
abzokhattab wants to merge 1 commit intoExpensify:mainfrom
Conversation
da1de9d to
291e654
Compare
Move the ineligible report filtering from IOURequestEditReportCommon into the useOutstandingReports hook so both the confirmation page and the report selection list see filtered results. This fixes the original bug (Expensify#70423) while avoiding the deploy blocker (Expensify#81608) that caused the previous fix to be reverted.
291e654 to
df2fba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Moves the ineligible report filtering logic from
IOURequestEditReportCommon.tsxinto theuseOutstandingReportshook. This ensures both consumers of the hook — the confirmation page (MoneyRequestConfirmationListFooter) and the report selection list (IOURequestEditReportCommon) — see filtered results. When all reports are ineligible, the confirmation page correctly disables the Report field instead of opening a blank page.Fixed Issues
$ #70423
Tests
Deploy blocker regression test:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos