Fix logging in parallel tasks after threading change#11
Merged
coleaeason merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
rafecolton
approved these changes
Mar 10, 2026
|
🚀 Released in version 1.20.7 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rafecolton Please review. A small bug from the threading change I noticed this morning:
The output from each task is missing the host string.
Fix by passing a thread local copy of the env into the sub thread that runs the task from the parent thread that runs each host connection: