Adjust to Deflect 0.12 v5 API, handle new PAN event#585
Adjust to Deflect 0.12 v5 API, handle new PAN event#585rdumusc merged 1 commit intoEyescale:masterfrom
Conversation
rdumusc
force-pushed
the
master
branch
2 times, most recently
from
83eca9a to
01b8b9c
Compare
eq/deflect/eventHandler.cpp
Outdated
| const auto sign = dx + dy; | ||
| const auto zoom = std::copysign( std::sqrt( dx*dx + dy*dy ), sign ); | ||
| event.pointerWheel.xAxis = 0.f; | ||
| event.pointerWheel.yAxis = zoom / 40.f; |
There was a problem hiding this comment.
where does the magic 40 come from?
There was a problem hiding this comment.
It's a bit of magic that was copied from the wheel event above and I cannot say that I understand what it corresponds to. Documentation for xAxis states: 'wheel rotation in clicks'. That value is then multiplied again by 0.05f in eqPly / seq / livre to move the camera...
eq/deflect/eventHandler.cpp
Outdated
| case ::deflect::Event::EVT_MOVE: | ||
| // no break; | ||
| case ::deflect::Event::EVT_PAN: | ||
| _proxy->setNavigationMode( |
There was a problem hiding this comment.
do we still need that mode + the print?
There was a problem hiding this comment.
If the mode is not set, the camera keeps rotating. I'm having a look if the print can be disabled
rdumusc
force-pushed
the
master
branch
2 times, most recently
from
9034b06 to
a807a9b
Compare
|
Turns out the print and the rotation mode were specific to Deflect, so I removed them. Now the Channel::drawOverlay() looks suspiciously empty, but I didn't remove the applyOverlayState() and resetOverlayState() calls just to be safe. Let me know if you think they can be removed too. |
|
They can be removed too then. Just NOP it like frameViewStart() a few lines above. |
|
OK, done! |
|
Typo 'Delfect' in PR title and commit msg |
|
+1 otherwise |
rdumusc
changed the title
2 participants
Needs: BlueBrain/Deflect#130