Skip to content

feat: Add mapResults to PaginationResult#106

Merged
luanpotter merged 1 commit intomainfrom
luan.map-results
Jan 26, 2026
Merged

feat: Add mapResults to PaginationResult#106
luanpotter merged 1 commit intomainfrom
luan.map-results

Conversation

@luanpotter
Copy link
Member

@luanpotter luanpotter commented Jan 26, 2026

This was extracted from the version on backend, keeps both of them in line for ease of replacement.

NOTE: as per our existing impl, this DOES NOT update the page size or any page computations. We mostly use it to batch process the list. To make a simple "couldn't do it with the other one" test, I opted to use a filter. I know that particular usage is potentially problematic depending on intent. Happy to change the test or consider alternatives.

@luanpotter luanpotter requested a review from a team January 26, 2026 19:12
@luanpotter luanpotter marked this pull request as ready for review January 26, 2026 19:12
Copy link
Collaborator

@QuinnB73 QuinnB73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luanpotter luanpotter merged commit 7fe0995 into main Jan 26, 2026
9 checks passed
@luanpotter luanpotter deleted the luan.map-results branch January 26, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants