Skip to content

fix: Introduce KspPropertiesWithAnnotationsResolver to fix annotations being lost from multi-sources with KSP2#121

Merged
luanpotter merged 1 commit intomainfrom
luan.get-all-annotations
Mar 17, 2026
Merged

fix: Introduce KspPropertiesWithAnnotationsResolver to fix annotations being lost from multi-sources with KSP2#121
luanpotter merged 1 commit intomainfrom
luan.get-all-annotations

Conversation

@luanpotter
Copy link
Member

@luanpotter luanpotter commented Mar 17, 2026

Test: #122

@luanpotter luanpotter force-pushed the luan.get-all-annotations branch from a38417f to 7acd74e Compare March 17, 2026 04:39
@luanpotter luanpotter marked this pull request as ready for review March 17, 2026 14:37
@luanpotter luanpotter requested review from a team and travisMiehm March 17, 2026 14:38
Copy link
Collaborator

@QuinnB73 QuinnB73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean workaround for the KSP2 annotation bug!

@luanpotter
Copy link
Member Author

@QuinnB73 unfortunate but necessary!

@luanpotter luanpotter merged commit ff258c4 into main Mar 17, 2026
8 checks passed
@luanpotter luanpotter deleted the luan.get-all-annotations branch March 17, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants