Skip to content

chore: Add tests for all remaining like cases, unify existing, make signature stricter#88

Merged
luanpotter merged 1 commit intomainfrom
luan.likes
Jan 2, 2026
Merged

chore: Add tests for all remaining like cases, unify existing, make signature stricter#88
luanpotter merged 1 commit intomainfrom
luan.likes

Conversation

@luanpotter
Copy link
Member

This will:

  • refine signature of like functions to use F & Any instead of String - while we know these have to be equivalent because there are no other subtypes of String, Kotlin doesn't know (this enables a future value adapter PR)
  • add a new LikeQueriesTest to centralize all test cases related to like and iLike
  • add missing test cases to touch all code paths
  • standardize spelling of iLike
  • standardize test names - remove references to "yawn", as all tests are yawn tests; use a what it test - what the query is pattern I've started to use on all tests

@luanpotter luanpotter merged commit cdf8472 into main Jan 2, 2026
7 checks passed
@luanpotter luanpotter deleted the luan.likes branch January 2, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants