Skip to content

feat: Add Long overloads to pagination model constructors #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luanpotter merged 1 commit into from
Jan 6, 2026
+11 −0
Merged

feat: Add Long overloads to pagination model constructors #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions yawn-api/src/main/kotlin/com/faire/yawn/pagination/PageNumber.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@ value class PageNumber private constructor(val zeroIndexedPageNumber: Int) {
get() = zeroIndexedPageNumber + 1

operator fun div(pageSize: Int): Page = Page(pageNumber = this, pageSize = pageSize)
operator fun div(pageSize: Long): Page = this / pageSize.toInt()

companion object {
fun zeroIndexed(pageNumber: Int): PageNumber = PageNumber(zeroIndexedPageNumber = pageNumber)
fun zeroIndexed(pageNumber: Long): PageNumber = zeroIndexed(pageNumber.toInt())

fun oneIndexed(pageNumber: Int): PageNumber = PageNumber(zeroIndexedPageNumber = pageNumber - 1)
fun oneIndexed(pageNumber: Long): PageNumber = oneIndexed(pageNumber.toInt())

fun starting(): PageNumber = PageNumber(zeroIndexedPageNumber = 0)
}
Expand Down
7 changes: 7 additions & 0 deletions yawn-api/src/test/kotlin/com/faire/yawn/pagination/PageNumberTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,11 @@ internal class PageNumberTest {
.isInstanceOf(IllegalStateException::class.java)
.withFailMessage("-1 is not a valid zero-indexed page number")
}

@Test
fun `can use Long overloads to create page numbers`() {
assertThat(PageNumber.zeroIndexed(0L).zeroIndexedPageNumber).isEqualTo(0)
assertThat(PageNumber.oneIndexed(1L).oneIndexedPageNumber).isEqualTo(1)
assertThat((PageNumber.starting() / 10L).pageSize).isEqualTo(10)
}
}
Loading