Add SerializationFeature.ORDER_SET_ELEMENTS for #3166#5780
Merged
cowtowncoder merged 7 commits intoFasterXML:3.xfrom Mar 22, 2026
Merged
Add SerializationFeature.ORDER_SET_ELEMENTS for #3166#5780cowtowncoder merged 7 commits intoFasterXML:3.xfrom
SerializationFeature.ORDER_SET_ELEMENTS for #3166#5780cowtowncoder merged 7 commits intoFasterXML:3.xfrom
Conversation
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
Avoid sorting attempts for Sets whose elements are not `Comparable`, and skip the temporary `ArrayList` allocation in that case. This is similar to the early check used by `MapSerializer._orderEntries`, while keeping the existing `ClassCastException` fallback for mixed `Comparable` types.
🧪 Code Coverage Report
|
cowtowncoder
changed the title
SerializationFeature.ORDER_SET_ELEMENTS for #3166
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3166
Retargeted to
3.xfrom #5776, per @cowtowncoder's suggestion.Summary
SerializationFeature.ORDER_SET_ELEMENTSto sort eligibleSetentries before serialization (disabled by default)SerializationFeature.FAIL_ON_ORDER_SET_BY_INCOMPARABLE_ELEMENTto control handling of non-Comparableor mutually incomparable elements (disabled by default)CollectionSerializerandStringCollectionSerializer, with an earlyComparablepre-check inCollectionSerializer._orderElementssimilar toMapSerializer._orderEntriesSortedSetandEnumSetunchangedTest plan
Set<Integer>,Set<String>,LinkedHashSetSortedSet/EnumSetpreserved as-is, including custom comparator orderComparableand mixed-type handling (fail/skip)nullelements, polymorphic serialization, custom content serializer fallbackThis is a Phase 1, databind-only change. Per-property annotation support (
JsonFormat.Feature) can follow separately.