Fix copy-on-write consistency in updateProperties isText path#834
Merged
cowtowncoder merged 2 commits into3.xfrom Mar 25, 2026
Merged
Fix copy-on-write consistency in updateProperties isText path#834cowtowncoder merged 2 commits into3.xfrom
cowtowncoder merged 2 commits into3.xfrom
Conversation
…operties The isText rename path was mutating the original propDefs list directly, while the wrapper name path correctly used copy-on-write. Apply the same pattern for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTextrename path inXmlBeanDeserializerModifier#updatePropertieswas mutating the originalpropDefslist directly viaset(), while the wrapper name path correctly used copy-on-write (new ArrayList<>(propDefs)on first mutation)Test plan
mvn test)🤖 Generated with Claude Code