Added option to stop and resume download #732
Conversation
|
I feel like "pause" might be better wording for this case. Also, it should probably replace the "Cancel" button. Clicking on "Pause" would change the "Pause" button to "Cancel" and have "Resume" button to appear on the right side. |
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
from
0cb8b13 to
e9202a5
Compare
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
from
e9202a5 to
111c84a
Compare
|
@grulja Rebased after |
grulja
left a comment
grulja
left a comment
There was a problem hiding this comment.
You didn't rebase properly and this change includes one of my changes I pushed recently.
I'm still unsure how to integrate this functionality UI/UX wise. Maybe what I suggested is not the best approach.
Hi, @allanday, I know you are quite busy, but would you be able to suggest a way how to best integrate this functionality?
Possible options are:
- As I suggested before, replace "Cancel" button with "Pause" when downloading, which will pause it and change the button to "Cancel" once paused. It will also make "Resume" button to appear on the right side.
- Keep "Cancel" button, but add a new option into the cancel dialog allowing you not to only cancel the whole process, but only pause it.
- Keep it as it is UI-wise, but once user confirms cancellation in the cancel dialog, do not return to the main page, but keep it on the same downloading page and make "Resume" or "Retry" button available to restart the process.
src/app/downloadmanager.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void DownloadManager::stopDownload() |
There was a problem hiding this comment.
This basically duplicates DownloadManager::cancel()
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
4 times, most recently
from
7fb3b6a to
1df4b49
Compare
gastoner
left a comment
gastoner
left a comment
There was a problem hiding this comment.
With this PR:
Screencast_20251205_133248.webm
Why, when you pause downloading, it asks whether you want to cancel verification? |
Signed-off-by: Evzen Gasta <[email protected]>
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
from
1df4b49 to
63fafc4
Compare
|
@grulja Should now display correct info |
3 participants
Closes #716