This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Fix Bazel build and add a GitHub action to exercise the build on different platforms#43
Merged
var-const merged 8 commits intoFirebaseExtended:masterfrom Aug 30, 2021
kimurayu45z:actions
Merged
Fix Bazel build and add a GitHub action to exercise the build on different platforms#43var-const merged 8 commits intoFirebaseExtended:masterfrom kimurayu45z:actions
var-const merged 8 commits intoFirebaseExtended:masterfrom
kimurayu45z:actions
Conversation
var-const
suggested changes
Aug 27, 2021
var-const
left a comment
var-const
left a comment
There was a problem hiding this comment.
Thank you! Overall this looks great, just a couple of nitpicks.
var-const
changed the title
var-const
approved these changes
Aug 30, 2021
This was referenced Aug 31, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extended branch from https://github.com/KimuraYu45z/protobuf-rules-gen/tree/master
so plz see #42 at first.
In this branch, I wrote the github actions workflow to emit the built binary files across platform matrix.
This can help M1 mac users and so on.